Skip to content

feat: support custom pretty placeholders - #380

Closed
clayzx wants to merge 1 commit into
fullstack-build:masterfrom
clayzx:feat/custom-pretty-placeholders
Closed

clayzx wants to merge 1 commit into
fullstack-build:masterfrom
clayzx:feat/custom-pretty-placeholders

Conversation

@clayzx

@clayzx clayzx commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

Applications need composite values such as HH:mm:ss.SSS styled as one token. Styling individual time placeholders leaves separators uncolored; v5 removed the old addPlaceholders hook.

Adds pretty.placeholders callbacks resolved before native ANSI/CSS rendering, with styles under pretty.styles. Includes types, validation, child inheritance, callback failure isolation, documentation and tests.

Validation: All node tests, 100% coverage, 9 browser tests across Chromium/Firefox/WebKit, and manual WeChat Developer Tools verification.

@terehov

terehov commented Oct 18, 2026

Copy link
Copy Markdown
Contributor

Thanks @clayzx! Merged your commit (with your authorship) into #386, which adds a few follow-ups from review (numeric return values, runtime validation for pretty.styles keys, docs placement, bundle budget) and targets the development branch, where all PRs land. Closing this one in favor of #386.

@terehov terehov closed this Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants