Repository navigation
ci: make shared runners selectable and isolate live login credentials - #27
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public repositories now use GitHub Ubuntu 24.04 in the same reusable Linux workflows; private repositories retain their caller-selected Blacksmith runners. A repository Actions variable,
CI_RUNNER, overrides the choice without changing scripts or browser coverage. Native macOS workflows keep their own runners.Test live accepts optional dedicated account credentials only for its browser step. Before installing dependencies or running tests it verifies the requested commit belongs to the default branch, preventing feature-branch code from receiving production test credentials.
Validation: all 51 workflow tests pass, including a real-Git regression that rejects feature commits before live credentials can be used. Independent reviews approved runner selection and live credential handling.