Skip to content

Make this library trimmable #164

Closed
Closed

Description

@albertwoo

Description

I am using this library in blazor wasm application, but this library's bundle size is 357kb. Which is a lot for a web application.
I also created similar ticket for FSharp.Data.Adaptive, which they already made it hanppen. fsprojects/FSharp.Data.Adaptive#104
And the result is pretty good.

Known workarounds

People can add below stuff to their own application to make it work. But it is better to have it support by default.

<Target Name="ConfigureTrimming" BeforeTargets="PrepareForILLink">
<ItemGroup>
	<ManagedAssemblyToLink Condition="'%(Filename)' == 'FSharp.Control.Reactive'">
		<TrimMode>link</TrimMode>
		<IsTrimmable>true</IsTrimmable>
	</ManagedAssemblyToLink>
</ItemGroup>
</Target>

Activity

  1. deviousasti commented on May 3, 2022

    @deviousasti
    Member

    This is a good idea. Does System.Reactive support trimming as well?

  2. deviousasti commented on May 3, 2022

    @deviousasti
    Member

    I don't think we explicitly need to specify TrimMode since link is the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions