Conversation
…is inert The comment above `global-config` asserted that the input disables autodiscover and keeps the sweep scoped to this repository. It does not, and has not on any run. Verified 2026-09-20 against the currently pinned `bfra-me/renovate-action@78e446d` (10.42.1): 1. `action.yaml:220` interpolates the value textually into a double-quoted shell assignment, stripping the JSON's own quotes. `jq` validation then fails and the step logs `Invalid JSON syntax in user global-config` followed by a fallback to base config, at exit 0. No JSON value survives. 2. The reusable workflow derives `autodiscover` from the repository name and passes it as an explicit action input, so a parsed global-config would be overridden regardless. This repo is named `.github`. Run 35487227927 (main, 2026-09-20) shows both: the fallback warning, and a sweep reaching org repos absent from `metadata/renovate.yaml`. Comment-only. Parsed YAML is identical before and after; no executable change, no behavior change, no guard weakened. The input is kept rather than deleted so the declared intent survives an upstream fix.
This was referenced Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment above
global-configin.github/workflows/renovate.yamlclaimed a scoping guarantee the control plane does not have:The input is discarded on every run, including the green ones. It has never once done what the comment says.
Two independent upstream causes
Both verified 2026-09-20 against the currently pinned
bfra-me/.github@5486c68(v4.30.0) ->bfra-me/renovate-action@78e446d(10.42.1).1. The value never survives the shell.
action.yaml:220interpolates it textually into a double-quoted assignment:user_global_config="${{ env.global_config }}"That is substitution, not expansion.
{"autodiscover": false}gets its own quotes eaten beforejqsees it, validation fails, and the step logs an error and then continues:Exit 0. The action already binds the value as an
env:var at line 75 — it just doesn't use it. The upstream fix isuser_global_config="$global_config".2. Even if it parsed, it would lose. The reusable workflow derives
autodiscoverfrom the repository name and passes it as an explicit action input:This repo is literally named
.github, so autodiscover is forced on for schedule and dispatch runs againstmain, whatever global config says.Observable net effect: run 35487227927 (main, 2026-09-20) emits the fallback warning and sweeps
fro-bot/fro-bot.github.ioandfro-bot/systematic— org repos absent frommetadata/renovate.yaml'swith-renovatelist, and therefore not excluded by the negative autodiscover filter.The bug survived
10.39.0 -> 10.42.1, so it is not transient.What this PR changes
The comment. Nothing else.
Parsed YAML is identical before and after — verified by parsing both revisions and comparing the resulting objects:
No executable change, no behavior change, no guard weakened, no version touched.
Why the comment and not the bug
The bug is upstream in two repositories. Neither is fixable from here, and both candidate local workarounds are worse than the defect:
So the input stays and the comment stops lying. A stale comment asserting a false isolation property is the exact failure mode flagged in
docs/solutions/workflow-issues/required-github-token-for-agent-steps-2026-06-22.md— keep the comments honest about the mechanism, because a stale comment documents a false guarantee for the next reviewer. This one had been documenting a false guarantee for months.Follow-up, not in this PR
bfra-me/renovate-actionfor the quoting bug.bfra-me/.githubfor the unconditional.github-name autodiscover.global-configis silently running on base config.Verification
The finding is resolved when a
Renovaterun log contains noInvalid JSON syntax in user global-configand its sweep names onlyfro-bot/.github. This PR does not achieve that and does not claim to — it makes the gap legible until upstream closes it.🤖 Generated by Fro Bot · run 35488760839