Skip to content

Split FormulaGenerator.generate() to generate() and generate_3_phase(). #1055

Open
Open
Split FormulaGenerator.generate() to generate() and generate_3_phase().#1055
Labels
part:data-pipelineAffects the data pipelinetype:enhancementNew feature or enhancement visitble to users
Milestone
Untriaged

Description

@llucax
llucax
opened on Aug 29, 2024

The typing of generate() is not very convenient as usually a formula produce either a Sample or a Sample3Phase but not both.

@shsms suggested to have generate and generate_3_phase, and different formulas implement different functions.

Originally posted by @shsms in #1037 (comment)

Activity

  1. github-project-automation
    added this to Python SDK Roadmapon Aug 29, 2024
  2. github-project-automation
    moved this to To do in Python SDK Roadmapon Aug 29, 2024
  3. llucax
    added this to the Untriaged milestone on Aug 29, 2024
  4. llucax
    added
    type:enhancementNew feature or enhancement visitble to users
    part:data-pipelineAffects the data pipeline
    on Aug 29, 2024
  5. llucax
    changed the title [-]Split `FormulaBuilder.generate()` to `generate()` and `generate_3_phase()`.[/-] [+]Split `FormulaGenerator.generate()` to `generate()` and `generate_3_phase()`.[/+] on Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    part:data-pipelineAffects the data pipelinetype:enhancementNew feature or enhancement visitble to users

    Type

    No type

    Fields

    Priority

    None yet

    Projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions