[docker] Multi-stage Dockerfile - #147
Merged
antonio-leblanc merged 2 commits intoMay 11, 2026
Merged
Conversation
antonio-leblanc
approved these changes
May 11, 2026
antonio-leblanc
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
nice results thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #144.
This rewrites the Dockerfile as a two-stage build: a builder that compiles
forefire and the Python bindings, and a runtime stage that just copies the
artifacts in. The toolchain (build-essential, cmake, python3-dev, netcdf-dev
headers) no longer ends up in the runtime image.
Numbers I just remeasured on Fedora 43, Docker 29:
tests/runff/ff-run.bashreturns EXIT=0 on the multistage image.I also dropped
tools/devops/Dockerfile.base,Dockerfile.multistage,readme.mdandentrypoint.shsince @antonio-leblanc confirmed in #144 thatthose were abandoned attempts. Left
tools/devops/increment-version.ymlalone, since it looks intentionally paused (moved out of
.github/workflows/in 2c337fa with the message "not needed now"). Happy to handle it in a
separate issue if you'd like.