Remove global ATS exception and document Keychain-backed secrets

CoderSwitch/App/AppContext.swift

@@ -1,4 +1,5 @@
 import Foundation
+import CoderSwitchCore
 import Observation
 
 /// Top-level container created exactly once at app launch. Owns the

CoderSwitch/App/CoderSwitchApp.swift

@@ -1,42 +1,233 @@
 import SwiftUI
+import CoderSwitchCore
 import AppKit
 
 @main
-struct CoderSwitchApp: App {
-    @State private var context = AppContext()
-    private let oauthStore = OAuthStore.shared
+enum CoderSwitchMain {
+    @MainActor private static var delegate: AppDelegate?
 
-    var body: some Scene {
-        MenuBarExtra("CoderSwitch", image: "CoderSwitchMenuBarIcon") {
-            StatusPopover()
+    @MainActor
+    static func main() {
+        let app = NSApplication.shared
+        let delegate = AppDelegate()
+        self.delegate = delegate
+        app.delegate = delegate
+        app.run()
+    }
+}
+
+@MainActor
+final class AppDelegate: NSObject, NSApplicationDelegate {
+    private let context: AppContext
+    private let oauthStore: OAuthStore
+    private var keepAliveActivity: NSObjectProtocol?
+
+    override init() {
+        let oauthStore = OAuthStore.shared
+        self.oauthStore = oauthStore
+        context = AppContext(oauthStore: oauthStore)
+        super.init()
+        AppShell.shared.configure(context: context, oauthStore: oauthStore)
+    }
+
+    func applicationDidFinishLaunching(_ notification: Notification) {
+        ProcessInfo.processInfo.disableAutomaticTermination("CoderSwitch menu bar utility")
+        ProcessInfo.processInfo.disableSuddenTermination()
+        keepAliveActivity = ProcessInfo.processInfo.beginActivity(
+            options: [.automaticTerminationDisabled, .suddenTerminationDisabled],
+            reason: "CoderSwitch menu bar utility"
+        )
+        NativeStatusItemController.shared.install()
+    }
+
+    func applicationWillTerminate(_ notification: Notification) {
+        if let keepAliveActivity {
+            ProcessInfo.processInfo.endActivity(keepAliveActivity)
+            self.keepAliveActivity = nil
+        }
+        ProcessInfo.processInfo.enableAutomaticTermination("CoderSwitch menu bar utility")
+        ProcessInfo.processInfo.enableSuddenTermination()
+    }
+
+    func applicationShouldTerminate(_ sender: NSApplication) -> NSApplication.TerminateReply {
+        if AppTerminationController.shared.shouldAllowTermination {
+            return .terminateNow
+        }
+        #if DEBUG
+        return .terminateNow
+        #else
+        return .terminateCancel
+        #endif
+    }
+}
+
+@MainActor
+final class AppShell: NSObject {
+    static let shared = AppShell()
+
+    private var context: AppContext?
+    private var oauthStore: OAuthStore?
+    private var settingsWindow: NSWindow?
+
+    private override init() {}
+
+    func configure(context: AppContext, oauthStore: OAuthStore) {
+        self.context = context
+        self.oauthStore = oauthStore
+        NativeStatusItemController.shared.configure(context: context, oauthStore: oauthStore)
+    }
+
+    func showSettingsWindow() {
+        guard let context, let oauthStore else { return }
+
+        if let settingsWindow {
+            NSApp.setActivationPolicy(.regular)
+            settingsWindow.makeKeyAndOrderFront(nil)
+            NSApp.activate(ignoringOtherApps: true)
+            return
+        }
+
+        let controller = NSHostingController(
+            rootView: SettingsWindow()
                 .environment(context.accountStore)
                 .environment(context.proxySettings)
                 .environment(context.proxyManager)
                 .environment(context.quotaPoller)
                 .environment(context.requestLogStore)
                 .environment(oauthStore)
-            Divider()
-            Button("About CoderSwitch") {
-                NSApplication.shared.orderFrontStandardAboutPanel(options: [
-                    .applicationIcon: NSImage(named: "CoderSwitchAppIcon") ?? NSApplication.shared.applicationIconImage
-                ])
-            }
+        )
+        let window = NSWindow(contentViewController: controller)
+        window.title = "CoderSwitch Settings"
+        window.styleMask = [.titled, .closable, .miniaturizable]
+        window.isReleasedWhenClosed = false
+        window.center()
+        settingsWindow = window
+        NSApp.setActivationPolicy(.regular)
+        window.makeKeyAndOrderFront(nil)
+        NSApp.activate(ignoringOtherApps: true)
+    }
+}
+
+@MainActor
+final class NativeStatusItemController: NSObject {
+    static let shared = NativeStatusItemController()
+
+    private var statusItem: NSStatusItem?
+    private weak var context: AppContext?
+    private weak var oauthStore: OAuthStore?
+    private var popover: NSPopover?
+    private weak var highlightedButton: NSButton?
+
+    private override init() {
+        super.init()
+    }
+
+    func configure(context: AppContext, oauthStore: OAuthStore) {
+        self.context = context
+        self.oauthStore = oauthStore
+    }
+
+    func install() {
+        guard context != nil, oauthStore != nil else { return }
+
+        let item = statusItem ?? NSStatusBar.system.statusItem(withLength: 32)
+        statusItem = item
+        item.isVisible = true
+        item.length = 32
+
+        guard let button = item.button else { return }
+        button.image = nil
+        button.title = "CS"
+        button.toolTip = "CoderSwitch"
+        button.setAccessibilityTitle("CoderSwitch")
+        button.setAccessibilityIdentifier("CoderSwitch.NativeStatusItem")
+        button.target = self
+        button.action = #selector(togglePopover(_:))
+        button.sendAction(on: [.leftMouseUp, .rightMouseUp])
+    }
+
+    @objc private func togglePopover(_ sender: NSStatusBarButton) {
+        guard let context, let oauthStore else { return }
+
+        if let popover, popover.isShown {
+            closePopover()
+            return
         }
-        .menuBarExtraStyle(.window)
 
-        Window("CoderSwitch Settings", id: "settings") {
-            SettingsWindow()
+        let popover = StatusPopoverPresenter.makePopover(
+            context: context,
+            oauthStore: oauthStore,
+            delegate: self,
+            openSettings: { [weak self] in
+                self?.closePopover()
+                AppShell.shared.showSettingsWindow()
+            }
+        )
+        self.popover = popover
+        highlightedButton = sender
+        sender.isHighlighted = true
+        popover.show(relativeTo: sender.bounds, of: sender, preferredEdge: .minY)
+    }
+
+    private func closePopover() {
+        popover?.close()
+        popover = nil
+        highlightedButton?.isHighlighted = false
+        highlightedButton = nil
+    }
+}
+
+extension NativeStatusItemController: NSPopoverDelegate {
+    func popoverWillClose(_ notification: Notification) {
+        popover = nil
+        highlightedButton?.isHighlighted = false
+        highlightedButton = nil
+    }
+}
+
+@MainActor
+private enum StatusPopoverPresenter {
+    static let contentSize = NSSize(width: 340, height: 720)
+
+    static func makePopover(
+        context: AppContext,
+        oauthStore: OAuthStore,
+        delegate: NSPopoverDelegate,
+        openSettings: @escaping () -> Void
+    ) -> NSPopover {
+        let content = ScrollView {
+            StatusPopover(openSettings: openSettings)
                 .environment(context.accountStore)
                 .environment(context.proxySettings)
                 .environment(context.proxyManager)
                 .environment(context.quotaPoller)
                 .environment(context.requestLogStore)
                 .environment(oauthStore)
         }
-        .windowResizability(.contentSize)
+        .frame(width: contentSize.width, height: contentSize.height)
 
-        Settings {
-            Text("CoderSwitch")
-        }
+        let hosting = NSHostingController(rootView: content)
+        hosting.preferredContentSize = contentSize
+        hosting.view.frame = NSRect(origin: .zero, size: contentSize)
+
+        let popover = NSPopover()
+        popover.behavior = .transient
+        popover.animates = true
+        popover.contentSize = contentSize
+        popover.contentViewController = hosting
+        popover.delegate = delegate
+        return popover
+    }
+}
+
+@MainActor
+final class AppTerminationController {
+    static let shared = AppTerminationController()
+    private(set) var shouldAllowTermination = false
+
+    private init() {}
+
+    func allowTermination() {
+        shouldAllowTermination = true
     }
 }