Repository navigation
Conversation
hhexo
changed the title
Contributor
Author
|
I'm going to look at doing our internal issue number 194 in this PR. |
hhexo
commented
Sep 28, 2017
| .stream() | ||
| .map((c) -> c.tryCoerceParam(ctx, param, evt)) | ||
| .filter(Optional::isPresent) | ||
| .map(Optional::get).findFirst(); |
Contributor
Author
There was a problem hiding this comment.
This stream usage looks nice but it was actually broken because findFirst() can return null and the subsequent arg.orElseThrow would break. A for loop is also more readable.
|
I'm sure sure if it solves my issue, JSON coercion is failing in my case when I send a null or empty message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An unsupported format is not a user input error - it's an FDK error, we can't even begin to send events to the function code.