Repository navigation
Conversation
C only applies the '+' and space flags to signed conversions, so
fmt::sprintf("%+u", 42) should give "42" like printf does, not "+42".
The same goes for %o, %x and %X.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fmt::sprintf applies the '+' and space flags to unsigned conversions, while C only applies them to signed ones (d, i, and the floating-point conversions):
This drops the sign for u, o, x and X before the type is normalized. %c, %s and the signed conversions are unchanged.
I added cases to the plus_flag and space_flag tests; they fail without the change and the full test suite passes with it. I also compared fmt::sprintf against glibc snprintf over a few hundred thousand random flag/width/precision combinations for d/i/o/u/x/X/c, and with this change the integer conversions all match.