Skip to content

Fix hexfloat zero padding: zero padding must be placed after the sign and "0x" prefix - #4972

Merged
vitaut merged 1 commit into
fmtlib:mainfrom
phprus:hexfloat-4971
Oct 8, 2026
Merged

vitaut merged 1 commit into
fmtlib:mainfrom
phprus:hexfloat-4971

Conversation

@phprus

@phprus phprus commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

Fix for issue #4971

@phprus
phprus requested a review from vitaut as a code owner October 4, 2026 20:37
@vitaut

vitaut commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

@arcobaleno64 please stop posting AI slop or you will be banned.

@arcobaleno64

Copy link
Copy Markdown

@arcobaleno64 please stop posting AI slop or you will be banned.

Understood, and apologies for the noise. I was using the comment as a timestamped review record, but I’ll stop posting these on third-party PRs.

Comment thread include/fmt/format.h Outdated
… and "0x" prefix

Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
@vitaut
vitaut merged commit 35c58f0 into fmtlib:main Oct 8, 2026
47 checks passed
@vitaut

vitaut commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants