Repository navigation
fix(site): pass flags through to wp-cli, exec and logs - #20
Merged
Merged
Conversation
- wp and exec stop parsing fly flags at the first argument, so 'fly wp plugin list --format=json' and 'fly exec php ls -la' work. --domain goes before the command. - exec uses the site's PHP service by default: php, or openlitespeed on OpenLiteSpeed sites (DefaultService, shared with wp). - exec reports an error when only a service name is given. - logs accepts --follow/-f, --tail and several services. - README: document flag passthrough and --domain placement. Closes #4
nabil1440
force-pushed
the
blockers/4-flag-passthrough
branch
from
September 22, 2026 06:36
96482cf to
3d17dc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
wpandexecstop the parse offlyflags at the first argument. All later arguments go to wp-cli or to the command without change.execuses the PHP service of the site by default:php, oropenlitespeedon OpenLiteSpeed sites.wpuses the same detection (docker.DefaultService).execwith only a service name shows an error.logsaccepts-f/--follow,--tailand more than one service.--domaingoes.Behavior change
--domainbefore the wp-cli command or theexeccommand, for examplefly --domain example.com wp plugin list. After the command,--domaingoes to wp-cli.--, for examplefly wp -- --info.Tests
splitService, andDefaultServicefor php, openlitespeed, both and none.dockerarguments for:wp plugin list --format=json--domain example.com wp plugin list --format=jsonexec php ls -laandexec ls -laexec lsandwp plugin liston an OpenLiteSpeed sitelogs -f phpandlogs --tail 50wpon an OpenLiteSpeed site, which Fix(ols): Fix cli not detecting OLS sites #1 corrected.fly exec php ls -la …,fly exec cat …andfly logs --tail 3 php.Closes #4