[camera] Integration tests require user interaction

@bparrishMines

I'm currently having to exclude the camera and camera_android tests from the new emulator CI tests I'm bringing up, because when they run a system dialog pops up asking for camera permissions. When running locally, if I tap it in the emulator everything runs fine.

It looks like this is probably a regression from flutter/packages#4348, because we have code in test_driver/integration_test.dart in the camera packages that is clearly supposed to handle this, by running adb commands once the process starts. Some options I can think of, although there may well be others:

Teach the repo tooling to use flutter drive for specific packages that opt out of flutter test. This will regress us in a way though, since flutter drive logs warnings that we should be using flutter test, and it's not clear to me if drive will even continue to be supported for non-web.
Find an alternate solution to grant permissions. E.g., can we grant them before the app is even installed, perhaps as part of emulator creation, or a new pre-test-run-script option in the repo tooling? I don't know what adb allows in that regard.
Add functionality to flutter test to allow for this in some way if possible (e.g., by allowing a custom driver even though one isn't normally used).

I'll be disabling this test in the emulator CI bringup for now to avoid blocking the rest of that work, via a new script/configs/exclude_integration_android_emulator.yaml file. When this is fixed, the exclusion should be remove from that file.

/cc @bparrishMines since he's been looking at the way integration tests run, the drive vs test differences, etc.

Infra-team I think this is a limitation after migrating to LUCI. The request would be to build a supported way to grant runtime permissions on android.

This was actually due to the flutter drive -> flutter test migration, rather than the LUCI migration. (It's related to LUCI only in that the LUCI migration allowed us to even run emulator tests at all.)

Ah thank you for the more accurate description.

Related to #86295

Lowering the priority for now as these tests are run in our device testing (just not on emulator).

There is an adb command that would work for this: https://developer.android.com/training/permissions/requesting#test-grant-all.

I wonder if it would make sense to make a flag that can be added to flutter test that passes -g to the adb command? Something like flutter test --grant-permissions?

I wonder if there is a similar flag/notion for other platforms.

Granting all permissions would be a sufficient workaround to prevent tests from failing due to the native permission dialog getting in the way 🤞

I also tried out adding this code snippet
Instrumentation instrumentation = InstrumentationRegistry.getInstrumentation();
if (Build.VERSION.SDK_INT >= 28) {
  instrumentation.getUiAutomation().grantRuntimePermission("io.flutter.plugins.cameraxexample", Manifest.permission.CAMERA);
  instrumentation.getUiAutomation().grantRuntimePermission("io.flutter.plugins.cameraxexample", Manifest.permission.RECORD_AUDIO);
}
to the integration_test FlutterTestRunner, and that also worked to grant permissions. Perhaps it would make sense to add a way to call that code snippet to the integration_test api.

Something like this exposed in the integration_test API would be an improvement on what's available for developers to use 🙌

@gmackall

This issue is assigned to @gmackall but has had no recent status updates. Please consider unassigning this issue if it is not going to be addressed in the near future. This allows people to have a clearer picture of what work is actually planned. Thanks!

@gmackall

This issue was assigned to @gmackall but has had no status updates in a long time. To remove any ambiguity about whether the issue is being worked on, the assignee was removed.

Navigation Menu

Repository navigation

[camera] Integration tests require user interaction #130987

5 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[camera] Integration tests require user interaction #130987

Description

Activity

reidbaker commented on Aug 24, 2023

stuartmorgan-g commented on Aug 24, 2023

reidbaker commented on Aug 25, 2023

5 remaining items

gmackall commented on Oct 19, 2023

gmackall commented on Dec 20, 2023

MarkOSullivan94 commented on Jan 26, 2024

flutter-triage-bot commented on Apr 24, 2024

flutter-triage-bot commented on Jul 10, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions