Android engine test flaking on failure to fetch dependencies

[zanderso]

Feature: Migrate gradle to use --offline mode to not download dependencies dynamically during CI.

In https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Android%20Debug%20Engine/20211/overview

ERROR: Failed to fetch maven artifact org.robolectric:android-all-instrumented:4.2.2_r1.2-robolectric-r1-i3

This flake is causing Android build/test times on CI to increase by several minutes due to automatic re-tries.

[reidbaker]

We should not be fetching dependencies as part of our CI. I am not familiar with this code but it is something my team can make sure gets fixed.

io.flutter.plugin.localization.LocalizationPluginTest > computePlatformResolvedLocale_selectOnlyLanguageLocale_beforeAndroidN[17] STANDARD_ERROR
    ERROR: Failed to fetch maven artifact org.robolectric:android-all-instrumented:4.2.2_r1.2-robolectric-r1-i3
    java.util.concurrent.ExecutionException: javax.net.ssl.SSLProtocolException: Connection reset
    	at com.google.common.util.concurrent.AbstractFuture.getDoneValue(AbstractFuture.java:552)
    	at com.google.common.util.concurrent.AbstractFuture.get(AbstractFuture.java:533)
    	at com.google.common.util.concurrent.AbstractFuture$TrustedFuture.get(AbstractFuture.java:90)
    	at org.robolectric.internal.dependency.MavenArtifactFetcher.fetchArtifact(MavenArtifactFetcher.java:97)
    	at org.robolectric.internal.dependency.MavenDependencyResolver.lambda$getLocalArtifactUrls$0(MavenDependencyResolver.java:80)
    	at org.robolectric.internal.dependency.MavenDependencyResolver.whileLocked(MavenDependencyResolver.java:100)
    	at org.robolectric.internal.dependency.MavenDependencyResolver.getLocalArtifactUrls(MavenDependencyResolver.java:75)
    	at org.robolectric.internal.dependency.MavenDependencyResolver.getLocalArtifactUrls(MavenDependencyResolver.java:65)
    	at org.robolectric.internal.dependency.MavenDependencyResolver.getLocalArtifactUrl(MavenDependencyResolver.java:116)

[reidbaker]

Links and resources that might be helpful
I think this is the test that failed. https://github.com/flutter/engine/blob/main/shell/platform/android/test/io/flutter/plugin/localization/LocalizationPluginTest.java
Luci python file https://flutter.googlesource.com/recipes/+/refs/heads/main/recipes/engine/engine.py

Command that failed to find any mention of localization plugin testing in recipe repo ❯ find . -type f -exec grep 'LocalizationPluginTest' {} \;

[reidbaker]

Main entry point for engine tests:
https://github.com/flutter/engine/blob/main/testing/run_tests.py

What I think is the most recent version of the dependencies that are available locally
https://chrome-infra-packages.appspot.com/p/flutter/android/robolectric_bundle/+/

Pull request that migrated android to the current dependency support.
flutter-team-archive/engine#17116

[reidbaker]

Current theory android-all-instrumented-4.2.2_r1.2-robolectric-r1-i4.jar is not included in the CIPD cash so gradle is downloading the dependency dynamically. I am working with @ricardoamador to try to prove that if CIPD has an update jar this issue is resolved.

Also note that gradle has an offline mode that will make our tests fail if we do not add the dependency to cipd. We might consider enabling it to see what breaks.
https://docs.gradle.org/current/userguide/dynamic_versions.html#sec:controlling_dependency_caching_command_line

[reidbaker]

PR to use offline mode
flutter-team-archive/engine#39465
Failed build
https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20Android%20Debug%20Engine/48013/overview

[reidbaker]

cipd create -pkg-def=somefile.yaml
Where somefile.yaml has the contents below from a directory that is the current contents of https://chrome-infra-packages.appspot.com/p/flutter/android/robolectric_bundle/+/ with any additional jars that need to be included in a folder named lib

package: flutter/android/robolectric_bundle
description: Dependencies for robolectric android testing
data:
    - dir: lib

[reidbaker]

CIPD has been update with a robolectric package but I am not sure if that will solve the initial flake on its own.

[reidbaker]

Another relevant link https://cs.opensource.google/flutter/engine/+/main:DEPS;l=662

[zanderso]

We can check in instructions for updating CIPD bundles here https://github.com/flutter/engine/tree/main/tools/cipd