feat(rule): support humanizeDuration in annotations - #14
Draft
andrewloux wants to merge 1 commit into
Draft
andrewloux wants to merge 1 commit into
andrewloux wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
duration annotations currently print raw seconds. this adds
humanizeDuration, so a query value of4800can render as1h 20m 0sthe renderer registers Prometheus's existing
HumanizeDurationhelper before parsing annotation templates.prometheus/commonbecomes a direct dependency at its existing versiontemplates can use
{{ $value | humanizeDuration }}or{{ humanizeDuration .Value }}. query values stay in seconds, and changing the formatted duration keeps the same alert identitytests render complete pod summaries across minutes, hours, and days using both syntaxes. the README documents the helper and its units
validated with
go vet ./..., the CI package test suite with-race -count=1, and a binary build. consumers must deploy this release before adding the helper to rule annotations