Skip to content
This repository was archived by the owner on Oct 25, 2024. It is now read-only.

Add fix and update unit tests for header gas limit calculation - #123

Merged
Wazzymandias merged 3 commits into
mainfrom
bugfix-builder-header-gas-limit
Oct 4, 2023
Merged

Add fix and update unit tests for header gas limit calculation #123
Wazzymandias merged 3 commits into
mainfrom
bugfix-builder-header-gas-limit

Conversation

@Wazzymandias

@Wazzymandias Wazzymandias commented Oct 3, 2023

Copy link
Copy Markdown
Contributor

📝 Summary

  • Update builder submission logic to calculate gas limit on payload attribute
  • Addresses long standing issue of blocks being rejected by relay on block validation due to invalid gas limit set on header
  • Tested with unit tests and on deployed service for several weeks to confirm the changes fix observed issue

📚 References

Loading
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dvush dvush Awaiting requested review from dvush dvush is a code owner
@TymKh TymKh Awaiting requested review from TymKh TymKh is a code owner
@avalonche avalonche Awaiting requested review from avalonche avalonche is a code owner
1 more reviewer
@Ruteri Ruteri Ruteri approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Wazzymandias @Ruteri