Skip to content
This repository was archived by the owner on Oct 25, 2024. It is now read-only.
This repository was archived by the owner on Oct 25, 2024. It is now read-only.

Does AddMevBundle need to use global pool mutex ? #7

Open

Description

@dmarzzz

AddMevBundle surely needs to lock for atomicity of adding to the bundle pool (pool.mevBundles), but as far as I can tell it doesn't interact with the rest of the txpool so should be okay to use something like pool.bundleMu.Lock()? Happy to implement if so 😃

Activity

  1. Ruteri commented on Nov 22, 2022

    @Ruteri
    Collaborator

    I think it's a good idea!
    Keep in mind pool.bundleFetcher is also accessed, but it can also be covered by the bundles-specific lock.

  2. dmarzzz commented on Nov 26, 2022

    @dmarzzz
    MemberAuthor

    awesome ty for heads up! will try and get a PR out this coming week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions