This repository was archived by the owner on Oct 25, 2024. It is now read-only.
Repository navigation
This repository was archived by the owner on Oct 25, 2024. It is now read-only.
Does this check in capella-1.11.5 branch break bundle cancellations? #52
Description
A block with cancelled bundles could have less profit.
builder/miner/payload_building.go
Line 102 in e72580c
Activity
[-]Does this check break bundle cancellations?[/-][+]Does this check in `capella-1.11.5` branch break bundle cancellations?[/+]Ruteri commentedon Mar 22, 2023
I think it's alright
The check here makes it so that only the most valuable payload makes it into the relay submission code. But all of those payloads have the cancelled bundles in consideration, and even if the resulting payload has a smaller profit than the previous relay submission it should be still sent.