Skip to content

fix(web): stabilize pull request loading layout - #2

Closed
flamboh wants to merge 2 commits into
t3code/reuse-pr-conflict-statusfrom
fix/pr-loading-layout
Closed

flamboh wants to merge 2 commits into
t3code/reuse-pr-conflict-statusfrom
fix/pr-loading-layout

Conversation

@flamboh

@flamboh flamboh commented Sep 20, 2026 •

Copy link
Copy Markdown
Owner

Note

🤖 GPT-6 on behalf of Oliver

Replaced by pingdotgg#12721.

ELI5

Keep the PR panel in place while its details load. Targets t3code/reuse-pr-conflict-status, the branch for pingdotgg#12545.

Problem

The skeleton used a larger author font, omitted the checkout command, and placed the branch and description differently. In the supplied images, branch text moved 4 pixels vertically and author text shrank from 32 to 22 pixels tall.

Fix

Match the loaded header, metadata rows, labels, and tabs. Show known content immediately, including the copyable checkout command and branch. Share the existing copy control and reserve space for edit controls and file counts. Remove the extra placeholder row above Description. Direct/thread opens also show the number-only checkout command when the host is known.

Validation: 146 focused tests pass, web typecheck passes, and targeted lint/format checks pass with existing lint warnings. Browser measurements found identical positions for author, checkout command, branches, tabs, metadata labels, and Description at 640px and 390px panel widths using a temporary PR fixture. The fixture was removed. Shared web/desktop panels are covered; native mobile is unchanged.

UI changes

Before, supplied screenshots:

Loading Loaded
Before loading Before loaded

After, the actual panel with a controlled local fixture matching PR pingdotgg#12533. The panel fills the capture viewport so unrelated project data is excluded.

Loading Loaded
After loading After loaded

Loading transition video

Implemented and reviewed with GPT-6 and GPT-5.6 Luna in Codex.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L labels Sep 20, 2026
@flamboh flamboh closed this Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant