Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
🤖 GPT-6 on behalf of Oliver
Replaced by pingdotgg#12721.
ELI5
Keep the PR panel in place while its details load. Targets
t3code/reuse-pr-conflict-status, the branch for pingdotgg#12545.Problem
The skeleton used a larger author font, omitted the checkout command, and placed the branch and description differently. In the supplied images, branch text moved 4 pixels vertically and author text shrank from 32 to 22 pixels tall.
Fix
Match the loaded header, metadata rows, labels, and tabs. Show known content immediately, including the copyable checkout command and branch. Share the existing copy control and reserve space for edit controls and file counts. Remove the extra placeholder row above Description. Direct/thread opens also show the number-only checkout command when the host is known.
Validation: 146 focused tests pass, web typecheck passes, and targeted lint/format checks pass with existing lint warnings. Browser measurements found identical positions for author, checkout command, branches, tabs, metadata labels, and Description at 640px and 390px panel widths using a temporary PR fixture. The fixture was removed. Shared web/desktop panels are covered; native mobile is unchanged.
UI changes
Before, supplied screenshots:
After, the actual panel with a controlled local fixture matching PR pingdotgg#12533. The panel fills the capture viewport so unrelated project data is excluded.
Loading transition video
Implemented and reviewed with GPT-6 and GPT-5.6 Luna in Codex.