Skip to content

BHP1-1607 - Add missing VMS units - #273

Merged
rjsheperd merged 6 commits into
mainfrom
rj-BHP1-1607-add-missing-units
Aug 5, 2026
Merged

BHP1-1607 - Add missing VMS units#273
rjsheperd merged 6 commits into
mainfrom
rj-BHP1-1607-add-missing-units

Conversation

@rjsheperd

Copy link
Copy Markdown
Contributor

Purpose

  • Add units were missing (m/s, K, lb/ft2, kg/m2, in2/in3, cm2/cm3,
    kW-s/m2, kJ/m/s, kJ/m/min, kJ/m2/s, kJ/m2/min, furlongs/fortnight, years,
    fraction for moisture).
  • Add CI workflow that runs the CLJS suite using headless Chrome on every PR

Depends on firelab/behave#69

Related Issues

Closes BHP1-1607

Submission Checklist

  • Included Jira issue in the PR title (e.g. BHP1-### <title>)
  • Code passes linter rules (clj-kondo --lint components/**/src bases/**/src projects/**/src)
  • Feature(s) work when compiled (clojure -M:compile-cljs)

Testing

  1. cd projects/behave && bb test:ci — 51 tests / 4216 assertions, green
    (includes new unit-conversion round-trips).
  2. Run the VMS (so 2026_07_29_add_missing_units.clj auto-migrates)
  3. Run app, sync
  4. Open Settings
  5. Verify that new units appear:
    • Fuel Load (lb/ft2, kg/m2)
    • SAVR (cm2/cm3, in2/in3)
    • Wind Speed (m/s)
    • Temperature (K)
    • ROS (m/s, furlongs/fortnight)
    • HPUA (kW-s/m2)
    • Fireline Intensity (kJ/m/s, kJ/m/min)
    • Heat Source & Reaction Intensity (kJ/m2/s, kJ/m2/min)
    • P-G Age of Rough (years)
  6. Verify that units can used in the Inputs (Wind Speed, Temperature)
    and are correctly displayed in Outputs (ROS, HPUA, Fireline Intensity)

@Kcheung42

Copy link
Copy Markdown
Collaborator

Looks good! approved.

@rjsheperd
rjsheperd merged commit a3cfcd5 into main Aug 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants