chore: reject circular references in tags - #280
Merged
Merged
Conversation
kevinmia
requested review from
a team,
TheUnderScorer,
ilfa and
necipallef
as code owners
September 29, 2026 22:33
Contributor
🚀 Following releases will be created using changesets from this PR:@fingerprint/react-native@4.0.0-rc.2Patch Changes
|
Contributor
Coverage report
Test suite run success95 tests passing in 6 suites. Report generated by 🧪jest coverage report action from f102cf0 Show full coverage report
|
TheUnderScorer
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caught this thread while doing testing around the v4 SDK pre-release: https://fingerprintjs.slack.com/archives/C050TKU9X5L/p1789981894548149.
Noticed that the Flutter SDK validates tags and rejects cycles, which isn't handled in this SDK. This PR updates things so that a circular
tagsobject throws a clearTypeErrornaming the exact path where the cycle closes, instead of an unhandledRangeError: Maximum call stack size exceeded.