[INTER-2190] Final V4 adjustments - #276
Conversation
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success91 tests passing in 6 suites. Report generated by 🧪jest coverage report action from 5b2a338 Show full coverage report
|
0f8b037 to
a8521fb
Compare
e5b3e05 to
8b0dfad
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Address validation error propagation and cross-platform tag and visitor ID contract issues before approval.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
Updates the SDK for Android 4.1.0, recursive tag validation, and empty visitor ID normalization.
Changes:
- Bumps the Android SDK dependency to 4.1.0.
- Adds tag validation and
InvalidArgumentError. - Normalizes empty native
visitor_idvalues toundefined.
| File | Summary |
|---|---|
sdk/src/types.ts |
Updates the visitor ID response contract. |
sdk/src/tags.ts |
Adds recursive tag validation. |
sdk/src/index.ts |
Exports validation APIs and errors. |
sdk/src/FingerprintClient.ts |
Applies validation and response normalization. |
sdk/src/errors.ts |
Defines invalid argument errors. |
sdk/android/fingerprint.gradle |
Bumps the Android SDK version. |
sdk/__tests__/tags.test.ts |
Adds tag validation tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
2eb0c0b to
5b2a338
Compare
🚀 Following releases will be created using changesets from this PR:@fingerprint/react-native@4.0.0-rc.1Major Changes
Minor Changes
|

visitor_idtoundefinedif it's emptyunknown_errorinstead offailedfor unknown errors on iOS