Famedly release/v1.158 - #22
Merged
Merged
Conversation
…n` (matrix-org#894) Follow-up to matrix-org#880 which introduces a better way to avoid the test pollution and obsoletes the need for all of this cleanup logic. See the PR description there for a more complete context on why. `WithWaitForLeave` was originally introduced in this context: > Many of the faster joins test flakes are due to the homeserver under test failing to contact Complement homeservers after they have been torn down. When this happens, subsequent tests can fail if they use a Complement homeserver that happens to have the same `hostname:port` as one which the homeserver under test has previously marked as offline. > > *-- matrix-org#626 But thanks to matrix-org#880 we no longer use the same `hostname:port` for engineered homeservers anymore. And we can go even further with cleaning this up by removing the need for `Destroy(...)` altogether, see matrix-org#895
…x-org#895) Follow-up to matrix-org#894 which removes another part of the clean-up code in this file and matrix-org#880 which introduces a better way to avoid the test pollution and obsoletes the need for all of this cleanup logic. See the PR description there for a more complete context on why. `Destroy(...)` was originally introduced in this context: > Since the partial state join tests reuse the same homeserver deployment, it is important that each test leaves the homeserver in an acceptable state for subsequent tests. In particular, we must allow in-progress partial-state joins to complete before tearing down Complement servers, otherwise the homeserver may mark Complement `hostname:port` combinations as offline and refuse to contact them in subsequent tests. > > *-- matrix-org#570 But thanks to matrix-org#880 we no longer use the same `hostname:port` for engineered homeservers anymore. --- Given the nature of these changes, this also fixes the goroutine panic that can happen when the waiter finishes after the test and `t` is used after the test finishes, see matrix-org#894 (comment)
…rix-org#885) * Update TestDemotingUsersViaUsersDefault regression test * Update TestPowerLevels tests * Update TestRoomDeleteAlias * Update TestRoomMembers * Update TestInboundFederationRejectsEventsWithRejectedAuthEvents * Update TestPartialStateJoin * Use existing RoomVersion object instead of making a new one * Borrow existing RoomVersion object from the ServerRoom * attempt to run match... function
jason-famedly
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.