Skip to content

Assets: Fix code comments and add return type - #18

Closed
Soean wants to merge 1 commit into
fairpm:mainfrom
Soean:improve-assets
Closed

Soean wants to merge 1 commit into
fairpm:mainfrom
Soean:improve-assets

Conversation

@Soean

@Soean Soean commented Jun 7, 2025

Copy link
Copy Markdown
Contributor

Improves the assets function:

  • Docs: replace_emoji_url() and replace_emoji_svg_url() don't have a parameter.
  • The return types are missing. We should add them to be consistent

Signed-off-by: Sören Wünsch <soeren.wrede@parshipgroup.com>
@joedolson

Copy link
Copy Markdown
Member

I've merged @szepeviktor's PR that includes this and several other code improvements; so I'm going to close this one as no longer needed. Thank you for contributing, @Soean!

@joedolson joedolson closed this Jun 8, 2025
@Soean
Soean deleted the improve-assets branch June 8, 2025 19:47
@rmccue rmccue added this to the 0.3.0 milestone Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants