Skip to content
This repository was archived by the owner on Jun 26, 2020. It is now read-only.
This repository was archived by the owner on Jun 26, 2020. It is now read-only.

☂️ Suspense umbrella task #1189

Description

@bvaughn

Misc

  • Keyboard navigation: Arrow key navigation for selected element is a bit broken. You can use down/right arrow to drill down into a Suspense component, but the up/left arrows won't drill back up. (It gets stuck at the component beneath Suspense.)
    arrowkey

Hiding timed-out children

react/react/pull/13823 changed the behavior of timed-out suspense trees. In order to preserve state (of both React components and host components) the timed-out tree now stays mounted, but gets hidden (e.g. "display: none").

For the GIF below, I used create-react-app with the following changes: https://gist.github.com/bvaughn/aab2a855c5fa1daa9ca55b1fdfac20a5

  • If the suspended subtree is expanded in the DevTools tree view, it gets auto-collapsed when it's hidden.
    collapse

  • The Profiler's render counter gets reset for all components in the hidden subtree. This makes it look like it's a new tree and might be confusing to people.

Testing

TODO @bvaughn and @acdlite will fill this in later.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions