Repository navigation
Return errors for corrupt sector chains instead of log.Fatal or reading forever - #6
Open
AntoniKwok wants to merge 1 commit into
Open
AntoniKwok wants to merge 1 commit into
AntoniKwok wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Damaged OLE2 containers currently crash or hang the host program:
StreamReader.Readcallslog.Fatalwhen a sector id is past the allocation table, terminating the process.Readreturn data forever /readMSATspin, so callers that read until EOF never finish.Seekindexessat[...]without a bounds check.Changes:
ErrCorruptChain;Read/Seekfollow chains through a helper that fails afterlen(sat)+1steps or on an out-of-table sector id (counted per call, so repeated seeks to the start are fine).Readstops at the stream's declared size (when known) and tracks the offset.readMSATrejects a revisited DIFAT sector.Tests cover a looping chain, an out-of-table chain and the size limit. Valid files read exactly as before (verified by parsing a 275 KB real-world workbook and comparing every cell).