Repository navigation
perf: cache parsed request queries - #7463
Closed
itsanickname-beep wants to merge 1 commit into
Closed
itsanickname-beep wants to merge 1 commit into
itsanickname-beep wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
|
Not caching You can find more details in: #6042 (comment) Duplicate of #6042 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Memoize
req.queryafter the first parse for the lifetime of a request. Applications that read the query object in multiple middleware layers no longer rerun the configured parser (including the more expensive extendedqsparser). Disabled query parsing retains its existing behavior.Performance audit: 10 opportunities
req.queryparsing (implemented here): eliminate repeated parser work per request; high request-path impact and a small isolated change.req.accepts*()negotiation results when the same request and candidate list are queried repeatedly.Acceptheader state on the request instead of constructing a newacceptsinstance for each negotiation call.req.protocol,req.host,req.ip, andreq.ipswithin a request.app.get()setting lookups in hot response paths by resolving stable settings once per request.Viewinstead of concatenatingthis.rooton every lookup.res.format()when the same content types are negotiated more than once.setHeaderdirectly after normalization rather than recursively dispatching throughres.set.Validation
git diff --checkpasses.