Repository navigation
fix: search example to support Redis v4+ and Express 4/5 - #6274
Merged
Merged
Conversation
wesleytodd
requested changes
Jan 12, 2025
wesleytodd
reviewed
Jan 12, 2025
vinybrun
force-pushed
the
fix-redis-example
branch
from
January 12, 2025 21:46
6d33482 to
4148e66
Compare
…zation into dedicated function to guarantee that it is complete before server starts
Contributor
Author
|
Hi @wesleytodd, I've made the requested changes:
I think this aligns with your feedback, but please let me know if I misunderstood or missed anything. Thanks! |
wesleytodd
approved these changes
Jan 14, 2025
wesleytodd
left a comment
Member
There was a problem hiding this comment.
Thanks for addressing the feedback. LGTM!
bjohansebas
approved these changes
Feb 1, 2026
bjohansebas
left a comment
Member
There was a problem hiding this comment.
LGTM. I don’t think we want to add more devDependencies, and it seems it was never the intention to add them, those were just examples.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Search example to address issues caused by breaking changes in Redis v4+ and Express 5.
Key changes include:
saddwithsAddandsmemberswithsMembersfor Redis v4+ compatibility.{0,1}syntax for optional parameters instead of?to support Express 5.These changes ensure the example works seamlessly.
Tested locally with:
Redis 7.0.15
Node.js 22.12.0
Express 5.0.1 and 4.21.2
Debian 12
Note:
Adding automated tests for this example could help catch issues like this sooner. If you think it's worthwhile, I’d be glad to help implement them.