Repository navigation
deps: upgrade mocha - #6121
deps: upgrade mocha#6121agungjati wants to merge 1 commit into
Conversation
wesleytodd
left a comment
wesleytodd
left a comment
There was a problem hiding this comment.
If we are going to update this can we move to ^ so we can stop this madness 🤣?
sheplu
left a comment
sheplu
left a comment
There was a problem hiding this comment.
Agree with @wesleytodd - but we should also do a global update not "per deps"
adb5592 to
1d5129f
Compare
|
Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
wesleytodd
left a comment
wesleytodd
left a comment
There was a problem hiding this comment.
I updated the pr to use ^ and add history entry. @sheplu mind taking a look and approving so we don't block?
Ah, I re-read this and accidentally didn't address this. I am not opposed to this but also don't feel too strongly either way. Since I already merged one of these PRs I guess I should stop until we decide which way we want to do this kind of update. I will wait for your reply before merging the rest and then we can adjust and force push if necessary. |
|
@sheplu and I discussed this and I am going to group all the other PR's into a single one so we reduce the noise in the repo and the history. I will use all the same commits, just rebase then squash them so @agungjati keeps the authorship. |
fix(deps): mocha@^10.7.3 (closes #6121) fix(deps): marked@^15.0.3 (closes #6120) fix(deps): express-session@^1.18.1 (closes #6119) fix(deps): ejs@^3.1.10 (closes #6117) fix(deps): content-type@^1.0.5 (closes #6115) fix(deps): connect-redis@^8.0.1 (closes #6114) fix(deps): supertest@^7.0.0 (closes #6112)
fix(deps): mocha@^10.7.3 (closes #6121) fix(deps): marked@^15.0.3 (closes #6120) fix(deps): express-session@^1.18.1 (closes #6119) fix(deps): ejs@^3.1.10 (closes #6117) fix(deps): content-type@^1.0.5 (closes #6115) fix(deps): connect-redis@^8.0.1 (closes #6114) fix(deps): supertest@^6.3.4 (closes #6112)
6 participants
Related: #6103 (comment)