Skip to content

remove makedirs command that wasn't working - #73

Merged
svlandeg merged 2 commits into
explosion:v3from
svlandeg:fix/windows
Aug 11, 2021
Merged

remove makedirs command that wasn't working#73
svlandeg merged 2 commits into
explosion:v3from
svlandeg:fix/windows

Conversation

@svlandeg

@svlandeg svlandeg commented Aug 11, 2021

Copy link
Copy Markdown
Contributor

Revert PR #42 - cf explosion/spaCy#6957 (comment)

We didn't actually need the mkdir statement there as spacy train takes care of this.

Adding 2 small fixes for spaCy versions here as well.

@svlandeg
svlandeg merged commit 5722d27 into explosion:v3 Aug 11, 2021
@svlandeg
svlandeg deleted the fix/windows branch August 11, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant