Repository navigation
Conversation
`with(record: ...)` assigned the record association and everything else went into params. Apps that add another belongs_to to Noticed::Event, such as an account to scope events by tenant, had to override `with` to pull it out of params themselves. Now any param named after a belongs_to association on the notifier is assigned the same way record is. Claude-Session: https://claude.ai/code/session_013hc6NU5mH5ytMmHbiEVtK5
Owner
Author
|
Closing this. Apps that need a default (like Jumpstart Pro's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notifier.with(record: ...)assigns therecordassociation and stores everything else inparams. Apps that add anotherbelongs_totoNoticed::Event, for example anaccountto scope events by tenant, have had to overridewithto pull it out ofparamsand assign it themselves. Jumpstart Pro does this in an initializer, and it's the most common reason people add columns tonoticed_events.Now any param named after a
belongs_toassociation on the notifier is assigned the same wayrecordis:Only
belongs_tonames are matched, so a param that happens to share a name with a column liketypeorparamsis left alone. Ephemeral notifiers are unchanged.Adds a test with an
AccountNotifierin the dummy app, a README note under therecord:explanation, and a changelog entry.https://claude.ai/code/session_013hc6NU5mH5ytMmHbiEVtK5