Skip to content

Remove rewriting of URLs via output buffer #76

Closed

Description

@ericclemmons

https://github.com/genesis/wordpress/blob/master/src/Genesis.php#L35-L41

If constants are set correctly (which they should be!), then there should be no need to rewrite the HTML upon delivery. The only reason this existed was because of sites using hard-coded URLs, but that behavior should not be encouraged at all.

If anything, URLs should omit the domain & just use the path.

This is a BC change, as it breaks expected behavior for existing projects

Activity

  1. added this to the v1.0.0 milestone on Jun 12, 2014
  2. EvanK commented on May 1, 2015

    @EvanK
    Contributor

    Still an issue for evolution/wordpress#37

    We'll be solving it there. Closing out...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions