Closed
Add regression coverage for InputRichMessage rich-text serialization shapes#2612
Conversation
Co-authored-by: Badiboy <5613421+Badiboy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code per review comment in PR #2610
Add regression coverage for InputRichMessage rich-text serialization shapes
Aug 12, 2026
Collaborator
|
@coder2020official Do we need this? :) |
Badiboy
marked this pull request as ready for review
August 12, 2026 14:30
Collaborator
|
I feel like it's useless, our tests coverage is non-existent anyways and this PR doesn't do much |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the review comment on rich message serialization coverage. It adds focused regression tests for the three supported
RichTextinput shapes when serialized throughInputRichMessage/InputRichBlock, including a subtype with required extra fields.Coverage added
RichTextobjectsSubtype regression guard
RichTextDateTimenested inside another rich-text nodeunix_timeanddate_time_formatsurvive serialization so incomplete subtype payloads are caughtScope
tests/test_types.py