Re-implement :has(> by marking first selector isRoot - #148
Open
lukaw3d wants to merge 5 commits into
Open
Conversation
This was referenced Aug 6, 2024
brettz9
added a commit
to brettz9/esquery
that referenced
this pull request
Aug 5, 2026
estools#148 hasSelector previously parsed a leading combinator (e.g. `> A > B`) by taking the whole remainder as an independent selector and wrapping it once with exactNode, producing a right-nested structure instead of the left-associative chain used by top-level selectors. This caused false negatives (`X:has(> A > B)` not matching valid nested structures) and false positives (matching when the :has() subject itself satisfied an inner constraint). Rebuild the chain the same way the `selector` rule does, seeding the left-associative fold with exactNode for the leading combinator. Regenerate parser.js from grammar.pegjs and add regression tests.
brettz9
added a commit
to brettz9/esquery
that referenced
this pull request
Aug 5, 2026
estools#148 hasSelector previously parsed a leading combinator (e.g. `> A > B`) by taking the whole remainder as an independent selector and wrapping it once with exactNode, producing a right-nested structure instead of the left-associative chain used by top-level selectors. This caused false negatives (`X:has(> A > B)` not matching valid nested structures) and false positives (matching when the :has() subject itself satisfied an inner constraint). Rebuild the chain the same way the `selector` rule does, seeding the left-associative fold with exactNode for the leading combinator. Regenerate parser.js from grammar.pegjs and add regression tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-implements #145 to fix #146
:has(>BlockStatement>ExpressionStatement)but this approach isn't extendable to support
:has(~and I don't know if it has unintended consequences if
>is used outside:has(>