Fix external agents detection

[nodo]

This PR fixes a bug when running entire enable having an external agents on the PATH.

Note

Medium Risk
Changes first-run agent auto-detection/preselection behavior to treat external agents differently, which can alter interactive setup outcomes and defaults for users with external binaries on PATH.

Overview
Adjusts detectOrSelectAgent so first-run auto-selection and default pre-selection only apply to built-in agents; if the only detected agent is external, the flow now falls through to the interactive selector instead of auto-accepting it.

Strengthens test isolation from host-installed external agents by filtering PATH in TestMain/test setup, and adds new tests with a mock entire-agent-* binary to validate external-only detection prompts and isBuiltInAgent behavior.

^{Reviewed by Cursor Bugbot for commit 68db6dd. Configure here.}

[Copilot]

Pull request overview

Adjusts agent detection/selection during initial setup so external agents don’t get auto-selected just because they’re the only detected agent.

Changes:

• Only auto-select a single detected agent on first run when it’s a built-in agent.
• Pre-select only detected built-in agents on first run (external agents remain opt-in via prompt).
• Add unit tests covering “external-only detected” prompting behavior and built-in/external classification.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
cmd/entire/cli/setup.go	Updates first-run auto-selection/preselection logic to exclude external agents; adds isBuiltInAgent helper.
cmd/entire/cli/setup_test.go	Adds test helpers for external agent binaries and new tests validating prompting/classification behavior.
cmd/entire/cli/global_test.go	Filters PATH in TestMain to avoid picking up real external agents during unit tests.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Test uses git.PlainInit instead of testutil.InitRepo
  • Replaced git.PlainInit in setupTestRepo with testutil.InitRepo and updated imports so all tests using this helper now get the required git test configuration.

Or push these changes by commenting:

@cursor push 079746b217

Preview (079746b217)

diff --git a/cmd/entire/cli/setup_test.go b/cmd/entire/cli/setup_test.go
--- a/cmd/entire/cli/setup_test.go
+++ b/cmd/entire/cli/setup_test.go
@@ -21,7 +21,7 @@
 	"github.com/entireio/cli/cmd/entire/cli/session"
 	"github.com/entireio/cli/cmd/entire/cli/settings"
 	"github.com/entireio/cli/cmd/entire/cli/strategy"
-	"github.com/go-git/go-git/v6"
+	"github.com/entireio/cli/cmd/entire/cli/testutil"
 )
 
 // Note: Tests for hook manipulation functions (addHookToMatcher, hookCommandExists, etc.)
@@ -44,9 +44,7 @@
 func setupTestRepo(t *testing.T) {
 	t.Helper()
 	tmpDir := setupTestDir(t)
-	if _, err := git.PlainInit(tmpDir, false); err != nil {
-		t.Fatalf("Failed to init repo: %v", err)
-	}
+	testutil.InitRepo(t, tmpDir)
 }
 
 // writeSettings writes settings content to the settings file.

_{This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.}

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 68db6dd. Configure here.}

[nodo]

@cursor push 079746b