Hooks stop deleting live idle sessions

[peyton-alt]

https://entire.io/gh/entireio/cli/trails/1413

Hooks stop deleting live idle sessions

Symptom. A session is re-initialised from scratch every few turns: transcript window, owner, and home reset, and a commit landing in the gap finds no session at all. In one clone a single session was re-initialised 37 times in four days.

Cause. The strategy's session listing, which every hook runs to match sessions, deletes any non-active state whose shadow branch is gone and whose checkpoint ID is empty. That is the normal shape of a healthy idle session right after a linked commit, or of a read-only session. Hooks in other worktrees list the same shared store, so any of them could delete it.

Fix. Orphan cleanup now deletes only finalized sessions (State.IsEnded: ENDED phase or EndedAt stamped) that were never condensed and carry no task records. Unfinalized IDLE states are never deleted by the listing: a live idle session stays, and a dead-owner one is left for finalizeExitedSessions, which marks it ENDED so the next listing clears it. Legacy empty-phase records normalize to IDLE, so — unlike before — they are kept until the 7-day StaleSessionThreshold expiry. entire status was already fixed to not delete on read (#2363); this covers the hooks.

Tests. Integration: another worktree's commit hook no longer deletes an idle session. Unit: the cleanup table keeps idle-with-dead-owner, idle-with-unknown-owner and legacy-empty-phase, and deletes ENDED never-condensed and IDLE-with-EndedAt states.

Follow-up. Hooks should not delete session state at all; deletion belongs to the sweeper, doctor and the 7-day expiry. That needs the orphan filter moved out of the shared listing and is tracked separately.

🤖 Generated with Claude Code

---

Note

Medium Risk
Changes shared hook-path session deletion logic for multi-worktree repos; incorrect owner liveness could retain stale state or still delete live sessions, but scope is narrowed and covered by new tests.

Overview
Fixes session re-initialization when git hooks in another worktree list the shared .git/entire-sessions/ store and treat a healthy IDLE session (no shadow branch yet, no LastCheckpointID) as orphaned.

listAllSessionStates now routes shadow-branch-missing cleanup through isOrphanedSessionState: IDLE states without checkpoint or task records are cleared only when OwnerExited() is true. ENDED/legacy never-condensed cleanup is unchanged; idle sessions with a live or unknown owner are kept until stale expiry.

Adds an integration test (linked worktree + parent commit hook) and expands unit tests for idle live/dead/unknown owner cases. Docs describe the new orphan rules.

^{Reviewed by Cursor Bugbot for commit 0f2dcb1. Configure here.}

[Copilot]

Copilot review overview

🟡 Changes recommended

A critical cleanup race remains, alongside legacy-state behavior and platform-specific test issues.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 · 1

Open (2)

• Lock and reload state before clearing orphaned sessions · New
• Preserve cleanup for legacy ownerless records · New

What changed in this PR

Fixes hook-driven deletion of live idle sessions by making cleanup owner-aware.

Changes:

• Adds owner-liveness checks for orphan detection.
• Expands unit and integration coverage.
• Documents revised cleanup behavior.

File	Description
docs/​development/​checkpoint-implementation.md	Documents orphan cleanup rules.
cmd/​entire/​cli/​strategy/​manual_commit_test.go	Expands cleanup behavior tests.
cmd/​entire/​cli/​strategy/​manual_commit_session.go	Implements owner-aware cleanup.
cmd/​entire/​cli/​integration_test/​session_state_idle_survives_test.go	Adds cross-worktree regression coverage.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.