Repository navigation
Make git-refs the sole enable default; drop backend picker - #1900
Conversation
Choosing the checkpoint backend during first-run setup added a storage-topology decision new users can't meaningfully answer. git-refs is already the recommendation, so write it silently and remove the interactive prompt. Branch stays reachable via --checkpoint-backend. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Entire-Checkpoint: 01KZ8MGVACAGY6FZR9173MD034
There was a problem hiding this comment.
🟢 Ready to approve
The change cleanly removes the interactive picker while preserving explicit flag selection and the env-override suppression behavior, with remaining tests covering the intended first-run defaults.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
This PR streamlines first-time entire enable by removing the interactive checkpoint-backend picker and making git-refs the sole default written on first run, while preserving non-interactive selection via --checkpoint-backend branch and honoring the ENTIRE_CHECKPOINTS_PRIMARY env override (so settings aren’t written when the env fully controls backend selection).
Changes:
- Removed the interactive checkpoint-backend picker (
promptCheckpointBackend/checkpointBackendChoices) and simplified first-run selection to: explicit flag wins, else first-run default. - Updated
runEnableInteractiveto use the new non-interactiveresolveFirstRunCheckpointBackendsignature. - Removed tests that only covered the deleted prompt/choice contract.
File summaries
| File | Description |
|---|---|
| cmd/entire/cli/setup.go | Simplifies first-run backend selection to flag-first, else git-refs default (or empty when env override is active). |
| cmd/entire/cli/setup_test.go | Drops the subtest that only exercised the removed prompt branch. |
| cmd/entire/cli/checkpoint_backend.go | Removes the huh-based picker helpers and prompt implementation. |
| cmd/entire/cli/checkpoint_backend_test.go | Removes tests that validated the now-deleted picker option ordering/labeling contract. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
https://entire.io/gh/entireio/cli/trails/975
Summary
entire enableno longer prompts new users to choose between the git-refs and branch checkpoint backends — a storage-topology decision they can't meaningfully answer during first-run setup.--checkpoint-backend branch.Changes
promptCheckpointBackend/checkpointBackendChoicesand thehuhpicker fromcheckpoint_backend.go.resolveFirstRunCheckpointBackend: flag wins, else git-refs default on first run.ENTIRE_CHECKPOINTS_PRIMARYenv override and the config-less git-branch runtime fallback are unchanged, so existing repos are untouched.Test plan
go build ./cmd/...go test ./cmd/entire/cli/ -run 'TestRunEnableInteractive_FirstRunDefaultsToGitRefs|TestResolveCheckpointBackendType|TestApplyCheckpointBackend|TestUpdateCheckpointBackend'— passcmd/entire/cli/...— 0 issues🤖 Generated with Claude Code
Note
Low Risk
Setup UX and default-selection logic only; env override, configure path, and legacy config-less behavior are explicitly preserved.
Overview
First-time
entire enableno longer asks users to pick checkpoint storage in an interactive form.git-refsis applied silently on first run (same as the former recommendation), while--checkpoint-backend branchstill selects the shared branch backend.The
huhpicker (promptCheckpointBackend/checkpointBackendChoices) is removed fromcheckpoint_backend.go, andresolveFirstRunCheckpointBackendis reduced to: explicit flag wins, else first-run default viafirstRunCheckpointBackendDefault()(still empty whenENTIRE_CHECKPOINTS_PRIMARYis set so settings are not written). Config-less repos keep the git-branch runtime fallback;entire configure --checkpoint-backendis unchanged.Tests for the picker contract and the headless “without
--yes” branch that only exercised the deleted prompt are dropped.Reviewed by Cursor Bugbot for commit 408435d. Configure here.