fix(web): thread error banner can be dismissed again - #97
Merged
Merged
Conversation
The fork integration dropped the session-scoped dismissal wiring from pingdotgg#6123, so dismissing a runtime stream error only cleared the local copy and the banner fell through to session.lastError. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude runtime stream errors shown in the banner at the top of a chat could not be clicked away. Dismissing cleared only the client-side error copy, and the banner immediately fell back to the error persisted on the thread's session (
session.lastError).The fix from upstream pingdotgg#6123 (session-scoped dismissal keyed by thread + message) was lost during the fork integration (
8872cabbc); the helpers inThreadErrorBanner.tsxremained but were unused. This restores the wiring inChatView: the banner and top-banner spacing use the maskedvisibleThreadError, and dismissing records the dismissal and forces a rerender. A new, different error on the same thread still shows.Verified with
vp test run apps/web/src/components/chat/ThreadErrorBanner.test.tsxand a web typecheck.Model: Claude Opus 5.5 (1M context). Harness: Claude Code.
🤖 Generated with Claude Code