Skip to content
This repository was archived by the owner on Aug 19, 2025. It is now read-only.

Wrap types in typing.Optional where applicable - #510

Merged
Kludex merged 3 commits into
encode:masterfrom
tsunyoku:fix-typing
Dec 17, 2022
Merged

Wrap types in typing.Optional where applicable#510
Kludex merged 3 commits into
encode:masterfrom
tsunyoku:fix-typing

Conversation

@tsunyoku

@tsunyoku tsunyoku commented Sep 24, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@Kludex

Kludex commented Oct 20, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hi @tsunyoku ! 馃憢
Would you mind enabling the flag https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-no-implicit-optional on our setup.cfg? That way, we can enforce those changes.

@tsunyoku

tsunyoku commented Oct 20, 2022

Copy link
Copy Markdown
Contributor Author

Hi @tsunyoku ! 馃憢 Would you mind enabling the flag https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-no-implicit-optional on our setup.cfg? That way, we can enforce those changes.

should be done!

Kludex
Kludex approved these changes Oct 20, 2022
View reviewed changes

@Kludex Kludex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 馃檹

@Kludex
Kludex merged commit 7aa1326 into encode:master Dec 17, 2022
@tsunyoku
tsunyoku deleted the fix-typing branch December 17, 2022 19:07
gaetano-guerriero pushed a commit to athenianco/morcilla that referenced this pull request Feb 27, 2023
@tsunyoku tsunyoku
@Kludex @gaetano-guerriero
Wrap types in typing.Optional where applicable (encode#510)
79ac95e 
Co-authored-by: tsunyoku <mbruhyo@gmail.com>
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@Kludex Kludex Kludex approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tsunyoku @Kludex