Broken RowProxy import with sqlalchemy 1.4 #298

Activity

1. Kyle-Verhoog

   changed the title [-]Broken import with sqlalchemy 1.4[/-] [+]Broken `RowProxy` import with sqlalchemy 1.4[/+] on Mar 15, 2021
2. brettlangdon

   added a commit that references this issue on Mar 15, 2021

   Fix starlette tests (#2172)

   ...

   c21411c
3. rafalp commented on Mar 15, 2021

   

   rafalp

   on Mar 15, 2021

   Contributor

   More actions

   Oh, so SQLAlchemy 1.4 is out now? That's great!

   PR fixing deps welcome <3

   👍React with 👍2Reacted by kyle and Vijay Yarramsetty
4. Kyle-Verhoog commented on Mar 15, 2021

   

   Kyle-Verhoog

   on Mar 15, 2021

   Author

   More actions

   I'm not very familiar with databases but I'm down to take a shot at fixing it up to learn more! 😄
5. laozhu commented on Mar 17, 2021

   

   laozhu

   on Mar 17, 2021

   Last edited by laozhu

   More actions

   I have the same problem here, I am using pymysql.

   File "./services/main.py", line 4, in <module>
       from services.core.database import create_tables
     File "./services/core/database.py", line 16, in <module>
       database_master = Database(_settings.database_master_url)
     File "/Users/Ritchie/Developer/@easynm/cloud/services/.venv/lib/python3.9/site-packages/databases/core.py", line 66, in __init__
       backend_cls = import_from_string(backend_str)
     File "/Users/Ritchie/Developer/@easynm/cloud/services/.venv/lib/python3.9/site-packages/databases/importer.py", line 21, in import_from_string
       raise exc from None
     File "/Users/Ritchie/Developer/@easynm/cloud/services/.venv/lib/python3.9/site-packages/databases/importer.py", line 18, in import_from_string
       module = importlib.import_module(module_str)
     File "/usr/local/Cellar/python@3.9/3.9.1_8/Frameworks/Python.framework/Versions/3.9/lib/python3.9/importlib/__init__.py", line 127, in import_module
       return _bootstrap._gcd_import(name[level:], package, level)
     File "/Users/Ritchie/Developer/@easynm/cloud/services/.venv/lib/python3.9/site-packages/databases/backends/mysql.py", line 9, in <module>
       from sqlalchemy.engine.result import ResultMetaData, RowProxy
   ImportError: cannot import name 'RowProxy' from 'sqlalchemy.engine.result' (/Users/Ritchie/Developer/@easynm/cloud/services/.venv/lib/python3.9/site-packages/sqlalchemy/engine/result.py)
   

   👍React with 👍3Reacted by Raja Simon, watsy0007 and Josue-T
6. noisywiz commented on Mar 19, 2021

   

   noisywiz

   on Mar 19, 2021

   More actions

   Hi! One more issue for 1.4 sqlalchemy/sqlalchemy#6096
7. rafalp commented on Mar 19, 2021

   

   rafalp

   on Mar 19, 2021

   Contributor

   More actions

   @rajasimon please pin dependencies to version if you are having problems.

   👍React with 👍1Reacted by noisywiz
8. PeterJCLaw

   added a commit that references this issue on Mar 19, 2021

   Work around encode/databases#298

   4deeb32
9. Basit-qc commented on Mar 22, 2021

   

   Basit-qc

   on Mar 22, 2021

   More actions

   Using databases[mysql]==0.4.2
   Had to downgrade sqlalchemy to sqlalchemy==1.3.23

   😕React with 😕1Reacted by Vijay Yarramsetty
10. lovelydinosaur commented on Mar 22, 2021

    

    lovelydinosaur

    on Mar 22, 2021

    Member

    More actions

    I'd suggest that the sensible first pass for us would be to issue a new release of databases that pins sqlalchemy properly in the setup.py. That'd at least ensure that pip install databases would function properly.

    We can then follow up with a PR that adds support for both 1.3 and 1.4, but we'll be under less time pressure to do so, so we're more likely to get it right, and users will have a working databases install in the meantime.

    👍React with 👍13Reacted by hashbangblob, Simeon Huang, Felipe Faria, Cory Dodt, Rafał Pitoń, Joshua Sleeper, Tom Hemmes, Brian, Zefeng Zhu, Arseniy Banayev and 3 more
11. vijaykumar1356 commented on May 26, 2021

    

    vijaykumar1356

    on May 26, 2021

    More actions

    @tomchristie Please do the needful update to have a support for 1.4 SQLAlchemy version
12. aminalaee

    closed this as completedin #299on Aug 26, 2021