Require node v24 for WASM_EXCEPTIONS feature - #27105
Merged
Merged
Conversation
sbc100
force-pushed
the
WASM_EXCEPTIONS
branch
2 times, most recently
from
June 11, 2026 21:28
495d889 to
136b22a
Compare
tlively
approved these changes
Jun 11, 2026
sbc100
enabled auto-merge (squash)
June 11, 2026 21:32
sbc100
changed the title
sbc100
force-pushed
the
WASM_EXCEPTIONS
branch
from
August 10, 2026 22:32
136b22a to
30c0daf
Compare
Collaborator
|
Out of curiosity, what inhibits this for Node.js 24? |
Collaborator
Author
|
IIUC node 24 requires a flag ( |
Collaborator
|
It is supported unflagged in Node.js 24, and I was even able to backport the full patchset to Node.js 22 as well (nodejs/node#62783) so it also works there unflagged. |
Collaborator
Author
|
Oh, if thats true then maybe the existing comment here is just wrong? In which case we can maybe move forward with landing this PR sooner rather than later since we just update emsdk node to v24: emscripten-core/emsdk#1760 |
sbc100
force-pushed
the
WASM_EXCEPTIONS
branch
from
August 10, 2026 23:05
30c0daf to
26c1e65
Compare
sbc100
changed the title
sbc100
force-pushed
the
WASM_EXCEPTIONS
branch
from
August 10, 2026 23:07
26c1e65 to
4dd3aa8
Compare
Collaborator
|
It was as of 24.15.0 in nodejs/node#62567. |
sbc100
force-pushed
the
WASM_EXCEPTIONS
branch
from
August 10, 2026 23:11
4dd3aa8 to
93d2207
Compare
sbc100
force-pushed
the
WASM_EXCEPTIONS
branch
from
August 10, 2026 23:12
93d2207 to
ff05efa
Compare
Collaborator
Author
|
Sorry the comment message used for the final merged commit was completely wrong .... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that Node 24 is shipping with emsdk we can remove this hack I think: emscripten-core/emsdk#1760.
We can also remove the
node_exception_flagshelper which was designed to let older versions of node run the program during typescript generation, but that use case doesn't seems useful/necessary anymore.Follow up #27103