Repository navigation
mkosi.bump: format version string - #886
danirabbit wants to merge 5 commits into
Conversation
Fixes #885 Outputs version string like `26.09.25+1501`
Installer builds for b29fd7bDo not use these installers for production systems. They are intended for testing purposes only. They will update to the latest PR build, which will break your install eventually.
|
|
Oh I guess it does change file name. Does that matter? |
|
Yes, it breaks updating existing daily installs #885 (comment) It's fine so long as we're okay with breaking dailies. |
|
let’s draft this for a second to think it through |
Remove hardcoded 9.0
Installer builds for b20d868Do not use these installers for production systems. They are intended for testing purposes only. They will update to the latest PR build, which will break your install eventually.
|
Installer builds for e5176b7Do not use these installers for production systems. They are intended for testing purposes only. They will update to the latest PR build, which will break your install eventually.
|
Installer builds for 253eefbDo not use these installers for production systems. They are intended for testing purposes only. They will update to the latest PR build, which will break your install eventually.
|
|
This might cause problems in the future because our
We might want to drop options 4 through 6 in that snippet. |
| set -e | ||
|
|
||
| date -u +%Y%m%d%H%M%S | ||
| date -u +%y.%m+%d%H%M |
There was a problem hiding this comment.
| date -u +%y.%m+%d%H%M | |
| date -u +%y.%m_%d%H%M |
We shouldnt use + here, it doesn't have to be underscore, but let's not use anything sysupdate might extend.
There was a problem hiding this comment.
Can you not just use a minus instead of an underscore here? It will look consistent in other places like the ISO file name elementary-os-proposed-x86-64-20260927-134251.iso.
There was a problem hiding this comment.
Actually, as I was trying to convey/suggest in my comments #886 (comment) and #886 (comment), why not just keep the "full" version without any special chars, so it's like 20260927134251 as a source of truth, then other places can extract/split whatever they need based on this core format, so if you want to just show elementary OS 26.09 in the system settings plug operating system view or name the ISOs elementary-26.09.27-134251-arm64.iso, or even (I'm about to open a ticket for this hah!) set the systemd-boot menu text like elementary OS daily (2026-09-27 134251) you're free to reformat whatever way you like.
|
Someone on social media brought up reproducible builds. In this vein, what do we think about just year and month for stable and only including the day/time for daily and proposed? |
@danirabbit i think you should always include the full build version string (like it's especially important even for stable builds because (if my understanding isn't wrong) you're no longer pulling package updates directly from apt/flatpak (ubuntu archives or appcenter/flathub remotes) but only deliver to users via image builds (off your R2 or whatever) so what i'm trying to say is even for stable builds/images you might need to build new images (new version strings) as frequently as multiple times on the same day for scenarios like urgent bug/security fixes either in elementary components/packages or external sources like apt/flatpak (ubuntu archives, appcenter/flathub remotes), right? |
|
in fact, if im reading the chatter on discord/github tickets right, why not keep the version string even more detailed and group the date and time together (not attach the day to the time) - meaning instead of leave the |
Fixes #885
Outputs version string like
26.09+251701