fix(infra): skip Cosmos offer reads on serverless accounts - #906
Merged
Merged
Conversation
createContainerIfNotExists still applies autoscale on provisioned databases. A 400 "offers is not supported for serverless" falls back to create without throughput so missing containers can be created on serverless accounts. Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
@effect-app/cli
effect-app
@effect-app/eslint-codegen-model
@effect-app/eslint-shared-config
@effect-app/infra
@effect-app/vue
@effect-app/vue-components
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Scanner EasyLife demo Dies on API startup:
createContainerIfNotExistscallsdb.readOffer()when creating a missing container with autoscale. Serverless Cosmos rejects offer read/replace with 400.What
If autoscale is configured and the container is missing, keep applying
maxThroughputon provisioned databases without shared throughput. WhenreadOffer(or the create) returns the serverless 400, create the container without throughput settings.How
isServerlessOfferErrormatches Cosmos 400 "not supported for serverless". The existing shared-offer / autoscale path is unchanged.Remarks
Fixes MACS-SCANNER-API-PD (scanner runtime). Scanner consumes this after the next
@effect-app/infrabeta.opened by Sentry in chat thread Discord · Discord · T3
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.