Skip to content

fix(engine): call session close synchronously - #36

Merged
ecryptoguru merged 1 commit into
mainfrom
fix/runner-close-sync
Jul 26, 2026
Merged

ecryptoguru merged 1 commit into
mainfrom
fix/runner-close-sync

Conversation

@ecryptoguru

Copy link
Copy Markdown
Owner
  • SQLiteSession.close is not a coroutine; awaiting it raises after the call.\n- Call it directly so the suppress block exits cleanly.\n\nLocal ruff + targeted runner tests pass.

SQLiteSession.close is not a coroutine; awaiting it raises after the call.

Call it directly so the suppress block exits cleanly.
@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@ecryptoguru, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 4 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d977cd43-5e5d-490b-a1d1-fe3c606522c7

📥 Commits

Reviewing files that changed from the base of the PR and between eee323d and ebf5f57.

📒 Files selected for processing (1)
  • strix/core/runner.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/runner-close-sync

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ecryptoguru
ecryptoguru merged commit 53faa52 into main Jul 26, 2026
2 checks passed
@ecryptoguru
ecryptoguru deleted the fix/runner-close-sync branch July 26, 2026 22:08
ecryptoguru added a commit that referenced this pull request Jul 30, 2026
Address CodeRabbit review on PR #41 — the parenthetical
'(PR #36 follow-up)' misattributed cache work to the synchronous
session-closing PR.
ecryptoguru added a commit that referenced this pull request Jul 30, 2026
* docs: add PR #22-#40 entries to UPGRADES.md ledger

Updates the ownership and upstream-import ledger with entries for
engine PRs #22 (Sol retirement, token caps), #26 (upstream sync
through 8157ccb), #33 (Azure GPT-5.6 hardening), #35 (cost/cache
optimization), #36 (synchronous session close), #39 (lint/type/viewer
fixes), and #40 (run.json progress fields).

* fix(docs): remove incorrect PR #36 cross-reference from cache entry

Address CodeRabbit review on PR #41 — the parenthetical
'(PR #36 follow-up)' misattributed cache work to the synchronous
session-closing PR.
@ecryptoguru
ecryptoguru restored the fix/runner-close-sync branch August 18, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant