Skip to content

Remove ByteBuddy indirection in ExecutionFlowFrameVisitor - #1575

Draft
ptziegler wants to merge 1 commit into
eclipse-windowbuilder:masterfrom
ptziegler:bytebuddy-cleanup
Draft

Remove ByteBuddy indirection in ExecutionFlowFrameVisitor#1575
ptziegler wants to merge 1 commit into
eclipse-windowbuilder:masterfrom
ptziegler:bytebuddy-cleanup

Conversation

@ptziegler

Copy link
Copy Markdown
Contributor

We use ByteBuddy to "augment" the visitor when traversing generic statements. This approach is time/memory intensive, as we need to create and load a new class, every time the Java file is parsed, but also difficult to debug, as the generated byte code lacks any meaningful debug information.

Instead the logic is embedded directly into the base visitor and dynamically enabled when this complex behavior is required.

@ptziegler ptziegler added this to the 1.25.0 milestone Aug 10, 2026
@ptziegler
ptziegler marked this pull request as draft August 10, 2026 20:34
@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown

Test Results

     4 files  ±0       4 suites  ±0   2h 23m 58s ⏱️ +54s
 7 023 tests ±0   6 992 ✅ +1  31 💤 ±0  0 ❌ ±0 
23 696 runs  ±0  23 598 ✅ +1  98 💤 ±0  0 ❌ ±0 

Results for commit 560469d. ± Comparison against base commit 0b3c72c.

♻️ This comment has been updated with latest results.

We use ByteBuddy to "augment" the visitor when traversing generic
statements. This approach is time/memory intensive, as we need to create
and load a new class, every time the Java file is parsed, but also
difficult to debug, as the generated byte code lacks any meaningful
debug information.

Instead the logic is embedded directly into the base visitor and
dynamically enabled when this complex behavior is required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant