Skip to content

Certificate authority - #188

Merged
tsvetlin merged 27 commits into
eclipse-arrowhead:developmentfrom
kovacskristof:certificate_authority
Mar 31, 2020
Merged

tsvetlin merged 27 commits into
eclipse-arrowhead:developmentfrom
kovacskristof:certificate_authority

Conversation

@kovacskristof

Copy link
Copy Markdown
Contributor

Updated Certificate Authority to version 4.1.3

@tsvetlin

Copy link
Copy Markdown
Contributor

Hello!

Thank you for submitting the request. We will review it shortly. Could you please provide documentation?

  • README, check it for examples of other core systems
  • Documents to the documentation folder

@rbocsi
rbocsi self-requested a review March 4, 2020 09:56
Comment thread certificate-authority/src/deb/control/postinst Outdated
Comment thread certificate-authority/src/deb/control/postrm Outdated
Comment thread docker-all/example/sql/setup.sql Outdated
Comment thread docker-all/example/sql/setup.sql Outdated
Comment thread scripts/certificate_authority_privileges.sql Outdated
Comment thread scripts/certificate_authority_privileges.sql Outdated

@rbocsi rbocsi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments

@kovacskristof

Copy link
Copy Markdown
Contributor Author

Added the requested modifications.

@kovacskristof
kovacskristof requested a review from rbocsi March 16, 2020 10:42
Comment thread certificate-authority/src/deb/control/postrm Outdated

@rbocsi rbocsi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found only one small issue (see inline comment). After fixing that you can merge to development

@kovacskristof

Copy link
Copy Markdown
Contributor Author

Thank you for the review!

@tsvetlin

Copy link
Copy Markdown
Contributor

Thank you for your contribution @kovacskristof!

@tsvetlin
tsvetlin merged commit 863f4e1 into eclipse-arrowhead:development Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants