Repository navigation
Wingman#7 structured logging baseline - #13
Merged
Merged
Conversation
Reconcile the preserved baseline with the wide-event controls already on main. Centralise settings-based setup at process entrypoints, document logging conventions and retention gaps, and run logging regression checks in CI. Refs #7 Co-authored-by: OpenAI Codex <noreply@openai.com>
Use a stable SHA prefix because the metadata branch placeholder is empty for pull request builds. Add the type hints and docstrings required by the Python contribution guidelines to the logging checks. Co-authored-by: OpenAI Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finalise the preserved structured logging work against current main. PR #11 already landed the formatter, redaction, request correlation and settings; this change reconciles the abandoned patch with those controls.
app.loggingas the settings-based setup entrypoint, reusing the existing JSON formatter.slack_botno longer changes the API's service label.docs/logging.md.mise run test-backendand CI.Validation:
mise run test-backendpasses all 23 tests, including the offline/healthrequest emitting exactly one JSON wide event. The focused run also passed all 20 streaming tests. Full-suite collection remains blocked intest_api.pyandtest_file_upload.pyby Slackauth.testwithout valid credentials, as recorded in #11; this PR's health check mocks Slack authentication and RAG initialization.Refs #7 (already closed by #11).
Parent deliverable: Wingman#7 structured logging baseline (
6h9PGXJWhfcvrfGH).Self-review: issue #7 coverage is complete; test type hints/docstrings were corrected to match
CONTRIBUTING.md. The first CI run passed tests and security checks, then exposed an existing image tag bug on pull requests ({{branch}}expands empty). Use the stablesha-prefix so both container build checks can run.Final verification: all PR checks passed, including both container builds, the expanded backend test task, CodeQL and Socket Security. Independent Standards and Spec reviews have no remaining findings.