fix(e6): default single-argument LOG to natural-log base e - #285
Merged
Conversation
DBR treats a single-argument LOG(x) as the natural logarithm (base e), but e6 requires an explicit base. Supply e = 2.718281828459045 so that single-arg LOG becomes LOG(2.718281828459045, x). DBR parses single-arg LOG(x) into an Ln node tagged with the original name, so handle that case too while leaving a genuine LN(x) untouched. Two-argument LOG(base, value) is unchanged.
gauravdawar-e6
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
DBR (and Spark/Hive/BigQuery) treat a single-argument
LOG(x)as the natural logarithm (basee). e6 requires an explicit base, so a single-argLOGcurrently transpiles toLOG(a), which fails at execution.This supplies the default base
e = 2.718281828459045(fetched from DBR'se()) whenever a single-argumentLOGis encountered:How
In the e6 generator:
exp.Logsingle-arg →LOG(2.718281828459045, x)(covers e6/presto/snowflake/postgres read paths, which produce aLognode).exp.Lnwhere the source function name waslog→LOG(2.718281828459045, x). This is the DBR path: Databricks parses single-arglog(a)into a natural-log (Ln) node tagged with the original name in meta. A genuineLN(x)is left asLN(x).Two-argument
LOG(base, value)is unchanged.Verified
log(a)LOG(2.718281828459045, a)log(a, b)LOG(a, b)ln(a)LN(a)log10(a)LOG(10, a)Tests
Added cases to
test_mathintests/dialects/test_e6.py(DBR single-arg, two-arg, e6 identity). Full e6 + databricks suites pass, no regressions.