fix(orch): count in-flight starts toward sandbox limit - #3667
Open
juliangoetze wants to merge 2 commits into
Open
juliangoetze wants to merge 2 commits into
juliangoetze wants to merge 2 commits into
Conversation
- reserve sandbox capacity atomically with the sandbox ID - count live sandboxes, in-flight starts, and checkpoint holds once - cover concurrent admission and server-level capacity regressions
juliangoetze
requested review from
ValentaTomas,
dobrac and
jakubno
as code owners
September 28, 2026 14:22
|
We require contributors to sign our Contributor License Agreement, and we don't have @juliangoetze on file. You can sign our CLA at https://e2b.dev/docs/cla . Once you've signed, post a comment here that says '@cla-bot check' |
Author
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
Author
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The per-node sandbox limit was checked after reserving the sandbox ID, using only the live sandbox count. Starts that were still in flight were not included. A burst of concurrent creates could therefore all observe available capacity and start more sandboxes than the configured node limit.
Changes
Testing
go vet ./pkg/sandbox/ ./pkg/server/go test -race -count=1 ./pkg/sandbox/ ./pkg/server/golangci-lint2.13.2gofmtandgit diff --checkThe Go checks were run in the repository-pinned Go 1.26.8 Linux environment.