Conversation
build.prod.ts caught the build error, printed it, and let the process exit 0, so `make local-build-base-template` reported success for a failed build. Set a failing exit code after logging the error.
lofoneh
requested review from
ValentaTomas,
dobrac and
jakubno
as code owners
September 24, 2026 09:08
|
We require contributors to sign our Contributor License Agreement, and we don't have @lofoneh on file. You can sign our CLA at https://e2b.dev/docs/cla . Once you've signed, post a comment here that says '@cla-bot check' |
Author
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build.prod.tscaught build errors, logged them, and exited 0, somake local-build-base-templatereported success for failed builds. It now setsprocess.exitCode = 1after logging.Verified by pointing
E2B_API_URLat an unreachable port:makeexited 0 before the change and 2 after.