Skip to content

feat(api): refactor template cache to redis - #1915

Merged
jakubno merged 5 commits into
mainfrom
feat/move-templates-cache-to-redis-eng-3064
Feb 19, 2026
Merged

jakubno merged 5 commits into
mainfrom
feat/move-templates-cache-to-redis-eng-3064

Conversation

@jakubno

@jakubno jakubno commented Feb 14, 2026 •

Copy link
Copy Markdown
Member

Note

Medium Risk
Touches a core caching layer and invalidation paths used by multiple handlers; mistakes could lead to stale reads or increased DB load despite being largely behavior-preserving.

Overview
Refactors TemplateCache to store template+build lookups in Redis (instead of in-memory), updating constructors/callers and adding Redis cluster-friendly keying plus context-aware invalidation. This also extends the shared RedisCache with optional key extraction and a SCAN-based DeleteByPrefix to efficiently invalidate all cached tags for a template, with tests updated/added to validate Redis deletion behavior and new cache wiring.

Written by Cursor Bugbot for commit 0669d92. This will update automatically on new commits. Configure here.

@linear

linear Bot commented Feb 14, 2026

Copy link
Copy Markdown

Comment thread packages/api/internal/cache/templates/cache_redis.go Outdated
Comment thread packages/api/internal/cache/templates/cache_redis.go Outdated
Comment thread packages/api/internal/cache/templates/cache_redis.go Outdated
Comment thread packages/api/internal/cache/templates/cache_redis.go Outdated
Comment thread packages/api/internal/cache/templates/cache_redis.go Outdated
Comment thread packages/api/internal/cache/templates/cache_redis.go Outdated
Comment thread packages/api/internal/cache/templates/cache.go Outdated
Comment thread packages/api/internal/cache/templates/cache.go Outdated
@jakubno
jakubno force-pushed the feat/move-templates-cache-to-redis-eng-3064 branch from c28940c to d6ab15c Compare February 14, 2026 17:21
@jakubno
jakubno changed the base branch from main to feat/alias-cache-refactor-to-redis-eng-3505 February 14, 2026 17:22
@jakubno
jakubno force-pushed the feat/move-templates-cache-to-redis-eng-3064 branch from 7106e23 to 83174fd Compare February 16, 2026 01:03
@jakubno
jakubno changed the base branch from feat/alias-cache-refactor-to-redis-eng-3505 to feat/add-the-refresh-logic-to-redis-as-well-eng-3506 February 16, 2026 01:10
Comment thread packages/api/internal/cache/templates/cache.go Outdated
@dobrac dobrac self-assigned this Feb 17, 2026

@dobrac dobrac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just nits

Comment thread packages/shared/pkg/cache/layered.go Outdated
Comment thread packages/shared/pkg/cache/layered.go Outdated
Comment thread packages/shared/pkg/cache/layered.go Outdated
Comment thread packages/shared/pkg/cache/layered.go Outdated
@jakubno
jakubno force-pushed the feat/add-the-refresh-logic-to-redis-as-well-eng-3506 branch from 4d4b6de to 34e40ea Compare February 18, 2026 17:11
Base automatically changed from feat/add-the-refresh-logic-to-redis-as-well-eng-3506 to main February 18, 2026 18:08
@jakubno
jakubno force-pushed the feat/move-templates-cache-to-redis-eng-3064 branch from ba29230 to c36f5c7 Compare February 18, 2026 20:06
@jakubno
jakubno marked this pull request as ready for review February 18, 2026 20:06

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c36f5c755f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/shared/pkg/cache/redis.go Outdated
Comment thread packages/shared/pkg/cache/redis.go Outdated
Comment thread packages/shared/pkg/cache/redis.go Outdated

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Comment thread packages/shared/pkg/cache/redis.go Outdated
@jakubno
jakubno merged commit e167890 into main Feb 19, 2026
61 of 62 checks passed
@jakubno
jakubno deleted the feat/move-templates-cache-to-redis-eng-3064 branch February 19, 2026 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants